Skip to content

fix(step-names): lowercase load-metrics and asymmetric DIFC Proxy start/stop names#29182

Merged
pelikhan merged 2 commits intomainfrom
copilot/fix-step-naming-inconsistencies
Apr 29, 2026
Merged

fix(step-names): lowercase load-metrics and asymmetric DIFC Proxy start/stop names#29182
pelikhan merged 2 commits intomainfrom
copilot/fix-step-naming-inconsistencies

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 29, 2026

Two step naming violations against the project's Title Case imperative-mood convention and symmetric Start/Stop pair pattern.

Changes

pkg/workflow/compiler_difc_proxy.go

  • Start DIFC Proxy for pre-agent gh callsStart DIFC Proxy — drops the context clause to match the symmetric Stop DIFC Proxy pair and align with Start MCP Gateway / Stop MCP Gateway pattern

.github/workflows/workflow-health-manager.md

  • load-metricsLoad Metrics — slug-style name replaced with Title Case display name

pkg/workflow/compiler_difc_proxy_test.go

  • Updated 3 assertions to expect the new step name

Lock files recompiled

auto-triage-issues, contribution-check, issue-arborist, stale-repo-identifier, daily-issues-report, workflow-health-manager

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile env md GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE er GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linurev-parse (http block)
    • Triggering command: /usr/bin/gh gh repo view owner/repo 0496�� 2609161027/.github/workflows CLJOlIPxV x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env t4277233828/.github/workflows GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x^remote\..*\.gh-resolved$ (http block)
    • Triggering command: /usr/bin/gh gh repo view owner/repo env or.md 4Gx5UXvR1 x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env t4277233828 GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE 013833/b078/ GOMODCACHE 64/pkg/tool/linu12345 (http block)
  • https://api.github.com/orgs/test-owner/actions/secrets
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq [.object.sha, .object.type] | @tsv user.email test@example.com /usr/bin/git -json .cfg x_amd64/compile git rev-�� --show-toplevel x_amd64/compile /usr/bin/git rtcfg GO111MODULE ache/go/1.25.8/xinstall git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv 4641-33752/test-2768671113 (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v5
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv 013833/b180/_pkg--workflow stmain.go ache/go/1.25.8/x--limit GOINSECURE fips140/ecdsa GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/link env 2643126808 flge/CEDVAjFSK2LRG6vPflge 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv --show-toplevel ache/go/1.25.8/x64/pkg/tool/linuInitial commit /usr/bin/git 01/main.md GO111MODULE ache/go/1.25.8/x: git rev-�� --show-toplevel ache/go/1.25.8/x64/pkg/tool/linuremote1 /usr/bin/git st-4088223914/.ggit pkg/mod/github.crev-parse /opt/hostedtoolc--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv --show-toplevel ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile /usr/bin/git 9640117/b466/_pkgit remote 9640117/b466=> git rev-�� --show-toplevel git /usr/bin/git s/test.md go /usr/bin/gh git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv mplied -trimpath g_.a -p set -lang=go1.25 /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linuremote.origin.url -o licyMinIntegrityOnlymin-integrity_with_repos_array_c3143634767/001 -trimpath 1/x64/bin/node l golang.org/x/modrev-parse -lang=go1.25 ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv runs/20260429-204641-33752/test-3423039704 -trimpath x_amd64/link -p main -lang=go1.25 x_amd64/link rev-�� -aw/git/ref/tags/v2.0.0 -dwarf=false bject.type] | @tsv go1.25.8 -c=4 -nolocalimports 76/PqKP-6X5LQwqikwE4oqH/1qH_NBc2vuK_iHp0mRJo (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv GOMODCACHE go ache/node/24.14.1/x64/bin/node -json til/net.go 64/bin/go git t-21�� k/gh-aw/gh-aw/.github/workflows/agent-persona-explorer.md test@example.com clusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle -json 90 64/bin/go git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v8
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv --show-toplevel 64/pkg/tool/linux_amd64/compile /usr/bin/infocmp archie.md -trimpath e/git infocmp -1 xterm-color e/git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v9
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv go1.25.8 -c=4 -nolocalimports -importcfg /tmp/go-build608013833/b244/importcfg -pack /home/REDACTED/go/pkg/mod/golang.org/x/text@v0.36.0/internal/number/common.go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv go1.25.8 -c=4 -nolocalimports -importcfg /tmp/go-build608013833/b131/importcfg -pack /home/REDACTED/go/pkg/mod/github.com/modelcontextprotocol/go-sdk@v1.5.0/mcp/client.go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel 64/pkg/tool/linuremote /usr/bin/infocmp _.a 0/internal/langurev-parse 64/pkg/tool/linu--show-toplevel infocmp -1 xterm-color 64/pkg/tool/linuremote.origin.url /usr/bin/git ithout_min-integgit GO111MODULE ache/go/1.25.8/x--show-toplevel git (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --get remote.origin.url 9640117/b458/vet.cfg -json GO111MODULE 64/bin/go node /tmp�� /tmp/TestHashConsistency_GoAndJavaScript2154177809/001/test-frontmatter-with-nested-objects.md go r,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,disp--show-toplevel -json GO111MODULE x_amd64/compile git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv GOMODCACHE Dk/Exs2fuW_hbdM5rev-parse /usr/bin/git _.a /semver/semver.grev-parse 64/pkg/tool/linu--show-toplevel /usr/bin/git conf�� --get-regexp ^remote\..*\.gh-resolved$ /usr/bin/git y_with_repos_arrgit bbyq8rTOi x_amd64/link git (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv 013833/b255/importcfg -trimpath g_.a =receive hash/maphash -lang=go1.25 (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv -bool -buildtags ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile -errorsas -ifaceassert -nilfunc ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile estl�� 9640117/b452/_pkg_.a -tests 9640117/b452=> -json GO111MODULE 64/bin/go git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv Zcz1/mu-Yc50W_kZqLXLFZcz1 (http block)
  • https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv /tmp/gh-aw-test-runs/20260429-204641-33752/test-766994756/.githugo1.25.8 (http block)
  • https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b
    • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq [.object.sha, .object.type] | @tsv . st/dist/workers/forks.js $name) { hasDiscussionsEnabled } } e-branch 66ee712cd26dad97--experimental-import-meta-resolve tions/setup/node--require git diff�� --binary 27e861d51221e11f--conditions ache/go/1.25.8/xdevelopment d2eaaf01..HEAD bb52a12cf7c4f0fb-C tions/setup/js/n/home/REDACTED/work/gh-aw/gh-aw/.github/workflows git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq [.object.sha, .object.type] | @tsv . st/dist/workers/forks.js bin/git e-branch 66ee712cd26dad97config t git diff�� --binary (http block)
  • https://api.github.com/repos/github/gh-aw
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw --jq .default_branch -output.go git r: $owner, name: $name) { hasDiscussionsEnabled } } -e 66bc70d54777c83c-C it 1/x64/bin/node ve . tions/setup/js/node_modules/vitest/suppress-warnings.cjs r: $owner, name: $name) { hasDiscussionsEnabled } } -exist mp 8ed268974e4e8284/home/REDACTED/work/gh-aw/gh-aw tions/setup/js/nshow (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw --jq .default_branch k/gh-aw/gh-aw main ed.lock.yml --require /home/REDACTED/wor-C ed } } go run k/gh-aw/gh-aw/.github/workflows git me: String!) { repository(owne-f l ings.cjs ed } } /opt/hostedtoolcshow (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0.1.2
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq [.object.sha, .object.type] | @tsv --show-toplevel 64/pkg/tool/linux_amd64/compile /usr/bin/gh _.a rotocol/go-sdk@vrev-parse 64/pkg/tool/linu--show-toplevel gh run download 2 /usr/bin/git test-logs/run-2 LamLkoYmy x_amd64/compile git (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv /tmp/TestGuardPolicyMinIntegrityOnlymin-integrity_with_repos_array_c3143634767/001 config ache/node/24.14.1/x64/bin/node remote.origin.urgit GO111MODULE 64/bin/go /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/compile t-19�� k/gh-aw/gh-aw/.github/workflows/archie.md -trimpath /usr/bin/git -p main -lang=go1.25 git (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv k/gh-aw/gh-aw/pkg/cli /tmp/go-build2049640117/b420/_testmain.go /opt/hostedtoolcache/node/24.14.1/x64/bin/node l GO111MODULE 64/bin/go node /tmp�� /tmp/TestHashConsistency_GoAndJavaScript21541778-test.timeout=10m0s go /usr/bin/git -json GO111MODULE x_amd64/compile git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-04-22 GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/asm env -json GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linufeature-branch (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-03-30 GOMOD GOMODCACHE 64/pkg/tool/linu-buildtags env _.a GO111MODULE 64/pkg/tool/linu-nilfunc GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linu/tmp/go-build2049640117/b111/vet.cfg (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-01-29 GOMOD GOMODCACHE 64/pkg/tool/linuorigin env _.a GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name V3gqgd2UJ 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linutest@example.com env g_.a 1iP8YSgUm ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE %H %ct %D (http block)
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 KjIdi_zAe ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE age GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile env 3009898726/custom/workflows GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE e/rtcov GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD bis 64/pkg/tool/linux_amd64/vet env lidations passed" op5fLH1pk x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 GO111MODULE ionpins.test GOINSECURE s.o 64/src/syscall/j--show-toplevel ionpins.test 0496�� 2609161027 DFryr79XR x_amd64/link GOINSECURE GOMOD GOMODCACHE x_amd64/link (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name 8kq6Gg-gh 64/pkg/tool/linux_amd64/link GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/link env ntdrain.test PumV21ljR ortcfg.link GOINSECURE GOMOD GOMODCACHE FYD7TXdX-i1ql3kueA/opxEl9d6gxDxhremote.origin.url (http block)
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 Fs27lbYse 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env or.md 4Gx5UXvR1 x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ez/mV92zmzFPRmGNYBL4292/sAw73LOqItVJx19RaiQF rtcf�� me) vZBL1k16k ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 LamLkoYmy x_amd64/compile GOINSECURE v3 GOMODCACHE x_amd64/compile env UHnj43LIy GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE eader GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu/tmp/file-tracker-test449019756/test2.lock.yml (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name hOYFQ3cxW 64/pkg/tool/linux_amd64/link GOINSECURE a20poly1305 GOMODCACHE 64/pkg/tool/linux_amd64/link env 4159306449/.github/workflows R30X4Bcts ortcfg.link GOINSECURE %H %ct %D (http block)
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 InX8DV7o_ ache/go/1.25.8/x64/pkg/tool/linux_amd64/asm GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-buildtags env 3009898726/custom/workflows GO111MODULE ache/go/1.25.8/x64/pkg/tool/linu-nilfunc GOINSECURE 013833/b013/ GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-tests (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name m0O72i2Jk 64/pkg/tool/linux_amd64/vet GOINSECURE rm GOMODCACHE 64/pkg/tool/linux_amd64/vet env 4159306449/.github/workflows BIoY6_isA k GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 dq87ptaK6 ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-buildtags env rtcfg cjNZiRS1g k GOINSECURE er GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-tests (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name h00yucQ7c 64/pkg/tool/linux_amd64/link GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/link env 4159306449/.github/workflows pKmvAbdZx ortcfg.link GOINSECURE GOMOD GOMODCACHE -4GmfpWzsnidAKUU7I/p67f43WHEJUTs-dwarf=false (http block)
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 KmEF_rn9z ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE go-sdk/jsonrpc GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile env TgduJ5Wp9 GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 GOMOD GOMODCACHE x_amd64/asm env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 o 64/src/runtime/a--show-toplevel x_amd64/vet env -json .cfg x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/contents/.github/workflows/shared/reporting.md
    • Triggering command: /tmp/go-build2049640117/b404/cli.test /tmp/go-build2049640117/b404/cli.test -test.testlogfile=/tmp/go-build2049640117/b404/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true -nolocalimports -importcfg /tmp/go-build608013833/b224/importcfg -pack env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v0.47.4
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq [.object.sha, .object.type] | @tsv --show-toplevel ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile /usr/bin/git CommaSeparatedCogit 4ACQ/f02Eva1ttQPrev-parse tartedAt,updated--show-toplevel git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linu-tests /usr/bin/git FieldEnforcementdu Wm62/0AF9NF0LSqr-k e/git git (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv 4641-33752/test-source-field-variant-3144412361/.github/workflows GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE /strconv GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile rtcf�� 013833/b089/_pkg_.a rg/x/oauth2@v0.35.0/internal/doc.go ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v2.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json 1.5.0/internal/xcontext/xcontext.go x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v3.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json 1.5.0/internal/mcpgodebug/mcpgodebug.go x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
  • https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq [.object.sha, .object.type] | @tsv 4641-33752/test-source-field-variant-3144412361/--thin GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE 013833/b029/ GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linuTest User estl�� efaultBranchFromLsRemoteWithRealGitcustom_branch4075400457/001' efaultBranchFromLsRemoteWithRealGitcustom_branch4075400457/001' ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE b/gh-aw/pkg/time-1 ache/go/1.25.8/xxterm-color ache/go/1.25.8/x64/pkg/tool/linuorigin (http block)
  • https://api.github.com/repos/nonexistent/repo/actions/runs/12345
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE go-sdk/oauthex GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linutest@example.com env 4641-33752/test-source-field-variant-3144412361/--thin GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE 013833/b029/ GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linuTest User (http block)
  • https://api.github.com/repos/owner/repo/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh workflow list --repo owner/repo --json name,path,state ortcfg.link GOINSECURE GOMOD GOMODCACHE FYD7TXdX-i1ql3kueA/opxEl9d6gxDxhremote.origin.url estl�� rtcfg GO111MODULE g_.a GOINSECURE 013833/b078/ GOMODCACHE ache/go/1.25.8/xrepos/{owner}/{repo}/actions/runs/12345/artifacts (http block)
  • https://api.github.com/repos/test-owner/test-repo/actions/secrets
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/test/repo
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch 3009898726/custom/workflows GO111MODULE ache/go/1.25.8/x64/pkg/tool/linu-nilfunc GOINSECURE 013833/b013/ GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-tests rtcf�� 013833/b069/_pkg_.a rg/x/text@v0.36.0/internal/tag/tag.go ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE hlite 013833/b013/symadownload ache/go/1.25.8/x1 (http block)
  • invalid.example.invalid
    • Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin https://invalid.example.invalid/nonexistent-repo.git e/git init�� ndor/bin/git git ode_modules/.bin/git =receive test@example.com--git-dir=/tmp/bare-incremental-PGsLJH /git (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

… step names

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/3a2ffbde-697e-4618-bbbb-05b8d5bdedd4

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix step naming inconsistencies in workflow lock files fix(step-names): lowercase load-metrics and asymmetric DIFC Proxy start/stop names Apr 29, 2026
Copilot AI requested a review from gh-aw-bot April 29, 2026 20:56
@pelikhan pelikhan marked this pull request as ready for review April 29, 2026 21:10
Copilot AI review requested due to automatic review settings April 29, 2026 21:10
@pelikhan pelikhan merged commit e0ee957 into main Apr 29, 2026
19 checks passed
@pelikhan pelikhan deleted the copilot/fix-step-naming-inconsistencies branch April 29, 2026 21:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates workflow step display names to comply with the repository’s Title Case / imperative-mood convention and to make DIFC Proxy Start/Stop step names symmetric.

Changes:

  • Renamed the DIFC proxy start step to Start DIFC Proxy (matching Stop DIFC Proxy) and updated related assertions.
  • Renamed load-metrics to Load Metrics in the workflow-health-manager workflow definition.
  • Regenerated affected workflow lock files to reflect the new step names / hashes.
Show a summary per file
File Description
pkg/workflow/compiler_difc_proxy.go Updates the emitted DIFC proxy start step name for symmetry/consistency.
pkg/workflow/compiler_difc_proxy_test.go Updates tests to assert the new DIFC proxy start step name.
.github/workflows/workflow-health-manager.md Renames a pre-agent step from slug-case to Title Case (Load Metrics).
.github/workflows/workflow-health-manager.lock.yml Regenerated lock output reflecting the updated step name and resulting hash changes.
.github/workflows/auto-triage-issues.lock.yml Regenerated lock output reflecting the updated DIFC proxy start step name.
.github/workflows/contribution-check.lock.yml Regenerated lock output reflecting the updated DIFC proxy start step name.
.github/workflows/daily-issues-report.lock.yml Regenerated lock output reflecting the updated DIFC proxy start step name.
.github/workflows/issue-arborist.lock.yml Regenerated lock output reflecting the updated DIFC proxy start step name (plus associated regenerated blocks).
.github/workflows/stale-repo-identifier.lock.yml Regenerated lock output reflecting the updated DIFC proxy start step name.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 9/9 changed files
  • Comments generated: 0

@github-actions github-actions Bot mentioned this pull request Apr 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🧪 Test Quality Sentinel Report

Test Quality Score: 93/100

Excellent test quality

Metric Value
New/modified tests analyzed 3 assertions (in 2–3 existing test functions)
✅ Design tests (behavioral contracts) 3 (100%)
⚠️ Implementation tests (low value) 0 (0%)
Tests with error/edge cases 3 (100% — already in tests being updated)
Duplicate test clusters 0
Test inflation detected Marginal (3 test lines : 1 production line, but expected for a multi-site rename)
🚨 Coding-guideline violations None

Test Classification Details

Test / Assertion File Classification Notes
TestGenerateStartDIFCProxyStep — step name assertion pkg/workflow/compiler_difc_proxy_test.go:326 ✅ Design Verifies observable compiled YAML step name
TestDIFCProxyStepOrderInCompiledWorkflow — start step contains assertion pkg/workflow/compiler_difc_proxy_test.go:434 ✅ Design Verifies end-to-end compiled output contains the renamed step
TestDIFCProxyStepOrderInCompiledWorkflow — step ordering index search pkg/workflow/compiler_difc_proxy_test.go:459 ✅ Design Verifies start step precedes stop step in compiled YAML

What Changed

The 3 modified test lines are pure maintenance updates syncing assertions to the production rename:

  • Production: "Start DIFC Proxy for pre-agent gh calls""Start DIFC Proxy" (1 line in compiler_difc_proxy.go)
  • Tests: 3 assertion strings updated to match the new step name

All assertions carry descriptive messages (e.g., "step name should be present", "compiled workflow should contain proxy start step"), satisfying the guideline requirement.

Build Tag

No Flagged Tests

No tests require review — all 3 changes are correct, necessary maintenance for a rename fix.


Language Support

Tests analyzed:

  • 🟨 JavaScript (*.test.cjs, *.test.js): 0 tests

Verdict

Check passed. 0% of modified assertions are implementation tests (threshold: 30%). The test changes are correct, proportional maintenance for the step-name rename, with full assertion messages and behavioral coverage.


📖 Understanding Test Classifications

Design Tests (High Value) verify what the system does:

  • Assert on observable outputs, return values, or state changes
  • Cover error paths and boundary conditions
  • Would catch a behavioral regression if deleted
  • Remain valid even after internal refactoring

Implementation Tests (Low Value) verify how the system does it:

  • Assert on internal function calls (mocking internals)
  • Only test the happy path with typical inputs
  • Break during legitimate refactoring even when behavior is correct

Goal: Shift toward tests that describe the system's behavioral contract — the promises it makes to its users and collaborators.

References: §25134094422

🧪 Test quality analysis by Test Quality Sentinel · ● 2M ·

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Test Quality Sentinel: 93/100. Test quality is excellent — 0% of modified assertions are implementation tests (threshold: 30%). The 3 changed test lines are correct, proportional maintenance for the step-name rename with full behavioral coverage and proper assertion messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[step-names] Fix step naming inconsistencies: lowercase "load-metrics" and asymmetric DIFC Proxy names

4 participants